Comparing to booleans gives false when they have the same value

I'm trying to implement an audit table using Entity Framework core 2.0. However, all the fields are being saved, not just the edited ones. I thought I could do a simple if statement. If the old value is not equal to the new value then it is a changed value.

However, this is not working for booleans. Two true booleans are coming out as not equal.

Here is my very simple code:

if (property.OriginalValue != property.CurrentValue)
{
auditEntry.OldValues[propertyName] = property.OriginalValue;
auditEntry.NewValues[propertyName] = property.CurrentValue;
}


Hopefully, you can see in the image that both OldValues and NewValues are true but it drops into the if statement when it shouldn't. I would like an if statement that compares strings, ints, booleans etc if possible.

OldValues

NewValues

if

if

if

property.OriginalValue

property.OriginalValue.GetType

property.CurrentValue

property.CurrentValue.GetType

2 Answers
2

Has to do with the fact that property.OriginalValue and property.CurrentValue are 2 objects. Since the 2 don't reference the same object they are never equal. Try comparing using .ToString() or something like: property.IsModified

Fixed it with this line:

if (((property.OriginalValue != null) ? property.OriginalValue.ToString() : "" ) != ((property.CurrentValue != null) ? property.CurrentValue.ToString() : ""))


By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.